New Feature: Table Diffing #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 30a3da8. Conflicts: demo/index.php lib/Caxy/HtmlDiff/HtmlDiff.php
| return $this->domNode; | ||
| } | ||
|
|
||
| public function setDomNode(\DOMElement $domNode) |
|
I can't really see anything else beyond annotations. |
|
@adamCaxy Review addressed, if you want to take another look. |
|
🍍 Looks good to me. Only thing was the annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature: Table Diffing
There is still quite a bit of work required on this before I would consider it "production-ready" for an open source release, but I'm hoping it will do for the project we're using this library on and will be a decent start on improving how tables are diffed in this library.