Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings "count(): Parameter must be an array... #65

Merged
merged 2 commits into from
Jan 6, 2018

Conversation

di-maroo
Copy link
Contributor

When running the code under PHP 7.1, I'm getting this:

Warning: count(): Parameter must be an array or an object that implements Countable in 
./vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiff.php on line 719

Warning: count(): Parameter must be an array or an object that implements Countable in 
./vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiff.php on line 570

There are two reasons:

  1. attempt to use count() on an object which doesn't implement Countable
  2. attempt to use count() on a string

@jschroed91
Copy link
Member

Hi @yojick thank you for the pull request - not sure how I missed this for so long... I’ll have this reviewed this week

@sdkcarlos
Copy link

When will be this pull request merged?

@jschroed91 jschroed91 merged commit 231250a into caxy:master Jan 6, 2018
@jschroed91
Copy link
Member

Merged! Thank you @yojick

@sdkcarlos
Copy link

Thank you @jschroed91 and @yojick , however the Packagist package stills on the v.0.1.5, do you have the hooks of the repository correctly configured?

@jschroed91
Copy link
Member

I will need to tag a new release @sdkcarlos I’ll do that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants