Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you like it!
Notes & clarifications,
I used your idea of merging this feature directly into the
Trainer.train
object, in order to do that I craeted_trainSet
so the code will be more DRY.I created two new tests that try to learn the
sin
function so I could test the cross validation - if you have a better idea for a test I would be glad to hear it.I noticed a few unit tests that were inconsistent (probable race conditions):