Memoization of methods that return Futures #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking API change because the existing methods have been renamed to `cachingSync` and `cachingSyncWithTTL`. The opinionated stance of ScalaCache is that you should use the async API and everything should be a Future. We also provide synchronous counterparts as a convenience, but the methods get slightly uglier names.
This is also a breaking change because the original methods have been renamed to `memoizeSync`
Now they take the form of e.g. `sync.cachingWithTTL`, which is slightly less ugly than `cachingSyncWithTTL`. Unfortunately I couldn't follow this pattern for memoize, because you end up with annoying ambiguous imports when you try to import both `scalacache._` and then `memoization._`.
cb372
added a commit
that referenced
this pull request
Sep 27, 2015
Memoization of methods that return Futures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Adds asynchronous versions of
scalacache.caching,scalacache.cachingWithTTLandscalacache.memoization.memoize. These methods wrap anf: => Future[V]and return aFuture[V].This involves breaking API changes, as I took this opportunity to reorganise the API.
scalacache.cachingis now calledscalacache.sync.caching.scalacache.cachingWithTTL.scalacache.memoization.memoizeis now calledscalacache.memoization.memoizeSync.scalacache.getSynchas been deprecated and replaced withscalacache.sync.get.