Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align hash functions in CBA with ACE/ACRE #47

Closed
Soldia1138 opened this issue May 29, 2015 · 5 comments
Closed

Align hash functions in CBA with ACE/ACRE #47

Soldia1138 opened this issue May 29, 2015 · 5 comments
Milestone

Comments

@Soldia1138
Copy link

The hash functions in CBA have been improvement mainly by ACRE (Hashlists etc.) which have been adopted by ACE. Currently the cba hashes and ace/acre ones are neither the same nor compat.

Would be a nice feature to give 3rd party scripts independency of ACE/ACRE but the same functionality.

List of differences:

  • hashCreate contains a TYPE_HASH designator which is only used by the isHash and not used by ACE/ACRE. How often is the isHashfunction used?
  • Add hashLists-functions

Could jump on that and create a merge-request, if pleased.

@commy2
Copy link
Contributor

commy2 commented Jul 30, 2016

for ACE, done in:
acemod/ACE3#4181
acemod/ACE3#4183
acemod/ACE3#4186
acemod/ACE3#4187
acemod/ACE3#4188

dunno about ACRE

@commy2 commy2 removed their assignment Jul 30, 2016
@jonpas
Copy link
Member

jonpas commented Jul 30, 2016

I think ACRE will use it's own implementation until we get around to changing it. Does this impact anything?

@commy2
Copy link
Contributor

commy2 commented Jul 30, 2016

No

@Soldia1138
Copy link
Author

Soldia1138 commented Aug 3, 2016

Yeah, tbh we switched to our own hashList implementation in the meantime and afaik we converted almost every hash to that. But nevertheless I will check. (We = ACRE2)

@commy2
Copy link
Contributor

commy2 commented Mar 5, 2017

CBA and ACE use the same system. ACRE can only be handled by the ACRE team and if there are missing features, pull requests.
Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants