-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align hash functions in CBA with ACE/ACRE #47
Comments
for ACE, done in: dunno about ACRE |
I think ACRE will use it's own implementation until we get around to changing it. Does this impact anything? |
No |
Yeah, tbh we switched to our own hashList implementation in the meantime and afaik we converted almost every hash to that. But nevertheless I will check. (We = ACRE2) |
CBA and ACE use the same system. ACRE can only be handled by the ACRE team and if there are missing features, pull requests. |
The hash functions in CBA have been improvement mainly by ACRE (Hashlists etc.) which have been adopted by ACE. Currently the cba hashes and ace/acre ones are neither the same nor compat.
Would be a nice feature to give 3rd party scripts independency of ACE/ACRE but the same functionality.
List of differences:
hashCreate
contains a TYPE_HASH designator which is only used by theisHash
and not used by ACE/ACRE. How often is theisHash
function used?Could jump on that and create a merge-request, if pleased.
The text was updated successfully, but these errors were encountered: