Remove caching of the target for now #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this is a common/known issue thats being worked on to do with github actions/cache on macOS actions-rs/cargo#111
cberner
approved these changes
Feb 27, 2021
| @@ -30,11 +30,6 @@ jobs: | |||
| with: | |||
| path: ~/.cargo/git | |||
| key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }} | |||
| - name: Cache cargo build | |||
| uses: actions/cache@v1 | |||
There was a problem hiding this comment.
Does the v2 release fix it?
There was a problem hiding this comment.
2.1.4 has the fix, but it seems there's some sort of gtar issue and i believe the v2 tag doesn't point at it -- actions/cache#528 . A few rust repos from the issues look like they have manually pinned to 2.1.4 to get the original issue fixed. So we could probably try that here alternatively, assuming the gtar issue doesn't happen?
There was a problem hiding this comment.
I see. Ok, I'll just merge this for now then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this is a common/known issue thats being worked on to do with github actions/cache on macOS
actions-rs/cargo#111
Causing some flakiness it looks like, similar to those bug reports. For some reason serde crate seems to be the issue for a lot of people curiously enough given reports of a tar issue.