@ParameterFile support #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 2, 2012 20:40
This does not support variable arguments currently. Some tests are currently written in JUnit because I am unable to figure out the interaction with both Maven, and TestNG.
probably not the best place for it, but it was the easiest), also for required Parameters changed the output message to be a bit more helpful.
annotations to be clearer.
|
Thank you for this contribution. Frankly spoken, looking at the rather zero comments in the past 10 years (!), it seems there is not much interest in such a feature, and I wonder if it actually should be JCommander's job to build configuration from multiple files (sounds more like what Jakarta Config will do). In the end, JCommander soley is a CLI parser, not an application framework, as the very first line of the docs say: "JCommander is a very small Java framework that makes it trivial to parse command line parameters.". If nobody objects, I will close this issue in the next days. |
|
Closing as announced two months ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello as per this thread (https://groups.google.com/forum/?fromgroups#!topic/jcommander/dE6UyojYiVE) I have implemented support for configuration files. This does not support variable arguments currently, as the method I use to read configuration files is via a Properties object, and it didn't occur to me that I can't have multiple keys.
In short you specify things as
@ParameterFile
@parameter(names="--conf")
File configurationFile;
I did add a Test class, originally I tried with TestNG but because of a few problems A) I couldn't run TestNG in debug mode in Eclipse it would just lock up, and B) It seemed like I had to do something with Maven to actually get the updated files to be tested against, and I didn't know how to do this.
There is still more work to do be done (multiple arity arguments, and a few more tests), but I wanted to get some feedback in the interim.