Implements #539: @Parameters(parametersValidators = <? extends IParametersValidator>)
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbeust I would kindly request your review please. :-) |
mkarg
force-pushed
the
rules
branch
2 times, most recently
from
72a5e23
to
f8b3801
Compare
cbeust
reviewed
Sep 1, 2022
mkarg
changed the title
@Parameters(rules = <? extends IRule>)@Parameters(parametersValidators = <? extends IParametersValidator>)
|
ℹ️ In contrast to the original comment, this PR implements #539 using different names than originally proposed. The new interface is called |
This was referenced Sep 3, 2022
cbeust
added a commit
that referenced
this pull request
Sep 3, 2022
fixed: missing null check introduced by PR #542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution to #539 by adding the new interface
IRule, and the newrulesattribute to@Paramters. An example demonstrating mutual exclusive parameters is excluded. Also a test is included.In contrast to #539 I dediced that it makes more sense to have rules at the
@Parametersannotation on the class rather than rules on the single@Parameterlevel. The reason is that it would be confusing for the reader if a rule spanning over two parameters is just provided at one parameter annotation. This situation cannot happen if rules can only be given at the class annotation instead of the field annotation.