Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing MBR plots #25

Closed
sjefboeren opened this issue Aug 1, 2016 · 4 comments
Closed

missing MBR plots #25

sjefboeren opened this issue Aug 1, 2016 · 4 comments
Assignees
Labels

Comments

@sjefboeren
Copy link

Thank you for this wonderful QC software. I do see a few possibilities for improvement though.
I like the Match Between runs plots very much. But, sometimes there are no graph’s in the “EVD: alignment” check page. A remark appears: Could not find a unique reference Raw file even though the data in the Evidence table seem okay. Changing “MatchBetweenRuns_wA” from auto to yes did not help. Can the software be changed to just show the data in the Evidence table?
Another issue that needs changes has to do with the injection naming. Short names nor best effort names are taken over in the PCA plots, PG: (LFQ) intensity distribution plots and PG: Contaminant per condition plot. Can it be changed to show the short name?

Thank you very much,

Sjef Boeren

report_v0.80.7_combined.pdf
evidence.txt

@cbielow
Copy link
Owner

cbielow commented Aug 1, 2016

concerning

issue 1: Your data is just too good :-) I made the check less stringent and it should produce a plot now
image

issue 2: the PCA plot works on data from proteinGroups.txt, where the groups do not neccesarily correspond 1:1 to Raw files (for which the user can set names manually in report_vXYZ_filename_sort.txt). So until I find time to also allow users to manually influence that mapping, the only other way is to use shorter names when assigning groups during MaxQuant configuration OR (for the tech savvy) shorten the names in proteinGroups.txt before running PTXQC.
I added a small note to the help section of the Html report.

The fixes will be available tomorrow on Github after a suite of tests runs through.

Thanks for reporting!

@sjefboeren
Copy link
Author

Thanks Chris. How about adding an extra column "group name" to ...filename_sort.txt table? By the way, what is the 'best effort' column used for?
Best regards,
Sjef

cbielow added a commit that referenced this issue Aug 2, 2016
@cbielow
Copy link
Owner

cbielow commented Aug 2, 2016

'best effort' is not used by PTXQC but is rather for informative purposes, so the user can see where/why the shortening does not work. Also, its a good basis to manually edit the names if user wants to replace the 2nd column with 'file x'...

@cbielow
Copy link
Owner

cbielow commented Aug 2, 2016

The extra-column for experimental groups is probably the way to go. The easiest way to do this is probably via 'raw file' and 'experiment' column in evidence.txt. Will open a separate ticket and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants