uniop_bool_helper and friends: Array support #1224
Conversation
This routine is supposed to return a logical Octave array. Do linear indexing on the flattened tolist output which will work on both Array and Matrix. Fixes #1221.
In fact it is failing elsewhere but the point of *this* test is to change the orientation of a vector.
cbm755
changed the title
There was a problem hiding this comment.
It should be all good otherwise. The test case
t = sym(true)
w = [t t]
isequal(t, t)
now works with or without Pythonic.
As a side note, I didn't know about functions such as transpose, flatten or unflatten before. Well, I should have just used transpose instead of reinventing the wheel in 136184d
inst/@sym/isAlways.m
Outdated
| 'if x is not None and x.is_Matrix:' | ||
| ' r = [a for a in x.T]' % note transpose | ||
| 'if isinstance(x, (MatrixBase, NDimArray)):' | ||
| ' r = [a for a in flatten(transpose(x).tolist())]' % note tranpose |
There was a problem hiding this comment.
I think we should do flatten(..., levels=1) here since we know we are flattening a list of list. This could have the advantage of catching some errors in case tolist gives us something funny. WDYT?
BTW I think using flatten from https://docs.sympy.org/latest/modules/utilities/iterables.html is a good idea. I should change my code to use this as well instead of itertools.chain.from_iterable, which has a longish name and returns an iterator.
For the record, flatten is documented in https://docs.sympy.org/latest/modules/utilities/iterables.html#sympy.utilities.iterables.flatten
There was a problem hiding this comment.
thanks, I had never read that. I agree limiting to levels=1 to avoid unsuspected surprises sounds good. I will try it.
There was a problem hiding this comment.
It's new to me as well :)
I think the functions defined in sympy.utilities.* are really well-written and useful. I'll try to use them when applicable.
This routine is supposed to return a logical Octave array. Do linear
indexing on the flattened tolist output which will work on both Array
and Matrix. Fixes #1221.