Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

hotfix: Correct dts header #5

Merged
merged 1 commit into from
Jul 1, 2015
Merged

hotfix: Correct dts header #5

merged 1 commit into from
Jul 1, 2015

Conversation

ValentinTrinque
Copy link
Contributor

Removal of a double definition of Definitions by: in the Gruntfile.js because it's not supported by DefinitelyTyped.

An error is raised when executing npm test (aiming to verify the correctness of the dts file) on the DefinitelyTyped repository.

@cbowdon
Copy link
Owner

cbowdon commented Jun 20, 2015

Do they not allow you to do a single line with comma-separated authors?

@ValentinTrinque
Copy link
Contributor Author

Just FYI, this is the error when I ran npm test :

----------------- For file:tsmonad/tsmonad.d.ts

expected '// Definitions: ' at line 4, column 1:

// Type definitions for TsMonad
// Project: https://github.com/cbowdon/TsMonad
// Definitions by: Chris Bowdon <https://github.com/cbowdon>
// , Valentin Trinque <https://github.com/ValentinTrinque>
^
// Definitions: https://github.com/borisyankov/DefinitelyTyped

However, when I do a single line with comma separation, it works but it creates an over-80-column line. DefinitelyTyped does not talk about column restriction in their guide so I guess it's ok.

@cbowdon
Copy link
Owner

cbowdon commented Jun 26, 2015

Would you like to add your name to the header on a single comma-separated line? You've put in some good work so it'd be nice to have you on there. If you're not bothered I'll just merge this as-is.

@ValentinTrinque
Copy link
Contributor Author

Having my name or not really doesn't matter to me. But I really appreciate your care. You can merge =)

cbowdon added a commit that referenced this pull request Jul 1, 2015
@cbowdon cbowdon merged commit 4350c47 into cbowdon:master Jul 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants