Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL and PostgreSQL CI #9

Merged
merged 20 commits into from
Aug 18, 2020
Merged

MySQL and PostgreSQL CI #9

merged 20 commits into from
Aug 18, 2020

Conversation

MarkHerhold
Copy link
Collaborator

@MarkHerhold MarkHerhold commented Jun 27, 2020

Adds Github Actions CI for both MySQL and PostgreSQL. Also adds support for more PostgreSQL columns. This should probably be a patch release as everything should be backwards compatible.

Changes:

  • support more PostgreSQL columns
  • added jest-runner-groups to separate tests between MySQL and PostgreSQL (incompatible schemas in some cases)
  • added config options to test against a local server
  • added undefined to RDSDataParameterValue
  • requires Docker to run
  • uppercase typeName for uniformity
  • simplified some tests
  • create a new table per test

Remaining:

  • test against more types on both DBs
  • debug timestamp column test

@MarkHerhold
Copy link
Collaborator Author

MarkHerhold commented Jun 28, 2020

oh, fun...

> rds-data@1.1.0 test-pg /home/runner/work/rds-data/rds-data
> jest --config jestconfig.json --group=pg "--runInBand" "--ci"

172.18.0.1:33214 - "POST /Execute HTTP/1.1" 500
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fd842c080f9, pid=7, tid=0x00007fd84bafab88
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode linux-amd64 compressed oops)
# Derivative: IcedTea 3.13.0
# Distribution: Custom build (Tue Oct  1 11:00:28 UTC 2019)
# Problematic frame:
# C  [_jpype.cpython-37m-x86_64-linux-gnu.so+0x430f9]  JPJavaEnv::NewLocalRef(_jobject*)+0x9
#
# Core dump written. Default location: /app/core or core.7
#
# An error report file with more information is saved as:
# /app/hs_err_pid7.log
#
# If you would like to submit a bug report, please include
# instructions on how to reproduce the bug and visit:
#   https://icedtea.classpath.org/bugzilla
#
[2020-06-28 03:07:00 +0000] [20] [INFO] Booting worker with pid: 20
[2020-06-28 03:07:00 +0000] [20] [INFO] Started server process [20]
[2020-06-28 03:07:00 +0000] [20] [INFO] Waiting for application startup.
[2020-06-28 03:07:00 +0000] [20] [INFO] Application startup complete.
{"loglevel": "info", "workers": 1, "bind": "0.0.0.0:80", "graceful_timeout": 120, "timeout": 120, "keepalive": 5, "errorlog": "-", "accesslog": "-", "workers_per_core": 1.0, "use_max_workers": null, "host": "0.0.0.0", "port": "80"}

edit: likely related to koxudaxi/local-data-api#38

@MarkHerhold
Copy link
Collaborator Author

It works locally and using act locally but not on GitHub 🤦‍♂️

@cbschuld
Copy link
Owner

Hey @MarkHerhold - great work here; there is a PR to address this now I noticed (I am sure you'll see as well) other than documenting it in the PR thread here - koxudaxi/local-data-api#69

@MarkHerhold
Copy link
Collaborator Author

MarkHerhold commented Jun 29, 2020

@cbschuld yeah I'm hitting different issues running that PR (after doing a docker build, etc) locally so it's unlikely it would work in CI. Discussion over here.

In the meantime, if you find any fundamental issues with my changes/approach (other than CI not working 🤣 ), please let me know. I'll keep working on this.

@MarkHerhold
Copy link
Collaborator Author

@cbschuld I think this is ready to go 👍
Please squash merge when you think it's ready.

@cbschuld cbschuld merged commit a2a9954 into master Aug 18, 2020
@cbschuld cbschuld deleted the ci branch August 18, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants