-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL and PostgreSQL CI #9
Conversation
oh, fun...
edit: likely related to koxudaxi/local-data-api#38 |
It works locally and using act locally but not on GitHub 🤦♂️ |
Hey @MarkHerhold - great work here; there is a PR to address this now I noticed (I am sure you'll see as well) other than documenting it in the PR thread here - koxudaxi/local-data-api#69 |
@cbschuld yeah I'm hitting different issues running that PR (after doing a docker build, etc) locally so it's unlikely it would work in CI. Discussion over here. In the meantime, if you find any fundamental issues with my changes/approach (other than CI not working 🤣 ), please let me know. I'll keep working on this. |
@cbschuld I think this is ready to go 👍 |
Adds Github Actions CI for both MySQL and PostgreSQL. Also adds support for more PostgreSQL columns. This should probably be a patch release as everything should be backwards compatible.
Changes:
jest-runner-groups
to separate tests between MySQL and PostgreSQL (incompatible schemas in some cases)undefined
toRDSDataParameterValue
typeName
for uniformityRemaining:
timestamp
column test