Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for checking if PR changes submodule #287

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

mkirilin
Copy link
Collaborator

This CI runs on pull request and checks whether the PR attempts to change reference to sc submodule. If so, it exiting with error, turns a PR into a draft PR, and leaves a comment:

"Submodule has been changed by this PR. This is forbidden by the repository policy. Your PR is turned into a draft PR."

Otherwise, it exits with success and does nothing.

@mkirilin mkirilin self-assigned this Feb 19, 2024
@mkirilin mkirilin force-pushed the ci-submodule branch 8 times, most recently from d08b94f to f723581 Compare March 4, 2024 14:29
@cburstedde
Copy link
Owner

Thanks; there may be a simpler way without checking out the submodules.

@mkirilin mkirilin force-pushed the ci-submodule branch 7 times, most recently from ed2e7f5 to 24d8790 Compare March 26, 2024 09:32
@mkirilin
Copy link
Collaborator Author

UPD: I've simplified the code by checking out the base repository's branch initially without. Fetching is no need anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants