Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unicode/utf8 support from an pullrequest in dan200/computercraft #435

Closed
ghost opened this issue Apr 30, 2020 · 4 comments
Closed

add unicode/utf8 support from an pullrequest in dan200/computercraft #435

ghost opened this issue Apr 30, 2020 · 4 comments
Labels
enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

dan200/ComputerCraft#532

@ghost ghost added the enhancement An extension of a feature or a new feature. label Apr 30, 2020
@Lemmmy
Copy link
Member

Lemmmy commented Apr 30, 2020

I'm concerned about how this would interact with #409 - we're essentially doubling down on being single-byte, fantasy console style.

@SquidDev SquidDev added the wontfix A bug which I won't fix or an enhancement which won't be implemented. label Apr 30, 2020
@SquidDev
Copy link
Member

While unicode terminal support would be fantastic, at this point I can't see an obvious way to do it without either duplicating an awful lot of functionality or introducing breaking changes.

If someone can some up with a reasonable design for how to approach this, it might be worth looking into, but as it stands it's not really sane.

@neumond
Copy link
Contributor

neumond commented Jun 26, 2020

Unicode support imposes lots of problems since many characters are wide (emoji, japanese, chinese symbols) and must take 2 character places. This makes it especially problematic if one sets cursor position in the middle of such character and writes something. OpenComputers terminal code has lots of quirks with these wide characters.

@Lemmmy
Copy link
Member

Lemmmy commented Jun 26, 2020

I agree. Part of the beauty of CC is the simplicity. While it's not as simple as, say, a run of the mill fantasy console, it's still very easy to work with and to understand (by design!), and bringing the endless quirks of Unicode is going to cause problems even for jedi

The update that introduced the new terminal font (with the teletext characters, etc.) introduced a variety of accents that greatly increased the potential language span of CC. But, it isn't, and never was, CC's responsibility to provide complete support for the diverse world of languages. This ties in to #474 quite interestingly - that issue can only introduce so many translations without Unicode support, but in my opinion, that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.
Projects
None yet
Development

No branches or pull requests

3 participants