Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutoff-based calling #20

Closed
ilarischeinin opened this issue Jan 19, 2016 · 11 comments
Closed

Cutoff-based calling #20

ilarischeinin opened this issue Jan 19, 2016 · 11 comments
Assignees

Comments

@ilarischeinin
Copy link
Member

callBins() uses CGHcall, which seems to expect the input to be a set of cancer samples, i.e. that there are a reasonable amount of aberrations in the set. When running with a single sample and/or non-cancer samples, it frequently fails.

I'm working on a simple cutoff-based calling that could be used instead in those cases.

It's in branch cutoff-calling of my fork.

@jiading
Copy link

jiading commented Mar 7, 2017

Hi,

do you know why I still get such error msg, even if I try to use the cutoff method?
Thanks!

callBins(copyNumbersSegmented,method=c("cutoff"), cutoffs=c(-0.1, -0.1, 0.1, 0.1))
Error: Command CGHcall() returned the following error message:
Error in CGHcall(seg, organism = organism, ...): unused arguments (method = "cutoff", cutoffs = c(-0.1, -0.1, 0.1, 0.1))
Please contact maintainer of package CGHcall: Mark van de Wiel mark.vdwiel@vumc.nl

@ilarischeinin
Copy link
Member Author

ilarischeinin commented Mar 7, 2017

Your installed QDNAseq package version must be too old, as it does not recognize the method and cutoffs arguments. Cutoff-based calling was added in QDNAseq 1.8, which was part of Bioconductor 3.3. The current Bioconductor release is 3.4 (and includes QDNAseq 1.10).

By the way, if you do not want to distinguish between gains and amplifications, you should specify only one positive value for cutoffs, not the same value twice. And similarly for losses and homozygous deletions, and negative values. So, if you want to make calling according to these cutoffs: loss < -0.1 ≤ normal ≤ 0.1 < gain, you should use cutoffs=c(-0.1, 0.1).

@jiading
Copy link

jiading commented Mar 7, 2017 via email

@ilarischeinin
Copy link
Member Author

exportBins(object, file="output.tsv", type="segments")

@jiading
Copy link

jiading commented Mar 7, 2017 via email

@ilarischeinin
Copy link
Member Author

I know what you mean, but that's not implemented, at least not currently. It's something for the special case of single samples only, and not for data sets of two or more samples. Starting from the table you pasted above, you could use the rle() function and some basic R coding to achieve what you're after.

(An approach for larger data sets that includes this kind of dimensionality reduction could be for example something along the lines of:

library(CGHregions)

calls <- callBins(object)
cgh <- makeCgh(calls)
regions <- CGHregions(cgh)

Now, object regions contains a data set of reduced dimensions.)

@jiading
Copy link

jiading commented Mar 7, 2017 via email

@jiading
Copy link

jiading commented Mar 10, 2017 via email

@ilarischeinin
Copy link
Member Author

Your object cgh is not of a type that CGHregions() is expecting. You must have missed one of the other lines of code I gave. This command class(cgh) should return "cghCall", but probably doesn't right now. If you cannot figure it out, include the outputs of print(cgh) and sessionInfo() here.

By the way, this discussion really is in the wrong place. It has very little to do with the QDNAseq package. There are e.g. mailing lists for general support on how to use R or Bioconductor.

@jiading
Copy link

jiading commented Mar 10, 2017 via email

@ilarischeinin
Copy link
Member Author

I see that fixed the previous error message you saw. But when I said that using CGHregions was "an approach for larger data sets", I meant that; it does not work for individual samples (for which I suggested using rle() plus some manual R coding to achieve what you're after). If you want to read more about CGHregions, here is the paper.

daoud-sie pushed a commit that referenced this issue Apr 11, 2017
* master: (351 commits)
  Fix noisePlot() for paired end data
  Bump R version number dependency (to what IRanges already requires)
  Add option to specify random seeds
  Bump development version number to 1.7.3
  Make package future optional
  Update vignette to use BiocStyle
  Add base package imports to fix Travis NOTEs
  Fix travis package installs
  Update NEWS, fix #18
  Update NEWS, close #20
  Move calculation of expected variance to its own function
  Smarter handling of user-provided cutoff values
  Grammar
  Deprecating argument 'ncpus' [#19]
  Fix newline in verbose messages
  Using futures for parallel processing [#19]
  Update NEWS. Close #19
  Add parallel loess correction estimation
  Add homozygous deletions and amplifications to cutoff calling
  Implement parallel segmentation also when using smoothing
  ...

From: Daoud Sie <daoud@Daouds-MacBook-Air.local>

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/QDNAseq@113827 bc3139a8-67e5-0310-9ffc-ced21a209358
HenrikBengtsson pushed a commit that referenced this issue Aug 31, 2019
* master: (351 commits)
  Fix noisePlot() for paired end data
  Bump R version number dependency (to what IRanges already requires)
  Add option to specify random seeds
  Bump development version number to 1.7.3
  Make package future optional
  Update vignette to use BiocStyle
  Add base package imports to fix Travis NOTEs
  Fix travis package installs
  Update NEWS, fix #18
  Update NEWS, close #20
  Move calculation of expected variance to its own function
  Smarter handling of user-provided cutoff values
  Grammar
  Deprecating argument 'ncpus' [#19]
  Fix newline in verbose messages
  Using futures for parallel processing [#19]
  Update NEWS. Close #19
  Add parallel loess correction estimation
  Add homozygous deletions and amplifications to cutoff calling
  Implement parallel segmentation also when using smoothing
  ...

From: Daoud Sie <daoud@Daouds-MacBook-Air.local>

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/QDNAseq@113827 bc3139a8-67e5-0310-9ffc-ced21a209358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants