Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding::CompatibilityError fix #3

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Encoding::CompatibilityError fix #3

merged 1 commit into from
Sep 18, 2018

Conversation

hughkolias
Copy link

Addressing issues due to decode64 returning an US-ASCII encoded string (see: thoughtbot/griddler#304).

Griddler email parsing expects a string in UTF-8.

@hughkolias hughkolias mentioned this pull request Sep 17, 2018
Closed
ccallebs
ccallebs approved these changes Sep 17, 2018
View reviewed changes
Copy link
Owner

@ccallebs ccallebs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Will merge later tonight and bump the minor version. Nice work!

@hughkolias
Copy link
Author

thanks @ccallebs

@ccallebs ccallebs merged commit 90bd18e into ccallebs:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccallebs ccallebs ccallebs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughkolias @ccallebs