-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine parameter help #127
Conversation
Output:
|
Rebased against current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and everything seems to work as expected with the help parameter itself. It correctly reads values from the config as well, so I'll approve and merge.
As a side note though, while trying to test each parameter again, I think I found a problem with the data_sync
setting. I'll open an issue and tag you.
This pull request is inspired by, contains and supersedes #123.
Inspired by the pull request opened by @Querela, this pull request contains minimal docstrings for all
kosh.param
s which will be displayed when calling thekosh
python entrypoint with the--help
parameter. It further refines the implementation provided by the pull request #123 to include not only values of parameters specified on the CLI together with the--help
parameter, but all available (as in default) parameter values. Last but not least, the commit f340866 drops the"".format()
string formatting function in favour of literal string interpolation (f""
).