Use a weak NSHashTable for managing open result sets
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the use of an `NSMutableSet` containing `NSValue` references for managing open `FMResultSet` objects. This eliminates the potential for crashes due to over-releasing result sets.
|
Do you have an example where a crash actually occurs? |
|
Yes, we were encountering crashes during development and are running in production on a fork with this change applied. The crash potential is pretty evident since the current implementation leverages |
|
I believe you- I just want a reproducible case first, so I can test this guy. It could be possible that you guys are misusing the api as well… |
|
Even without a reproducible test case for the crash, using NSHashTable instead of NSMutableSet with NSValue-wrapped result sets is a good idea. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the use of an
NSMutableSetcontainingNSValuereferences for managing openFMResultSetobjects. This eliminates the potential for crashes due to over-releasing result sets.