Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-36 - Organize Environment and Logger init #48

Merged
merged 2 commits into from
Jun 10, 2024
Merged

ISSUE-36 - Organize Environment and Logger init #48

merged 2 commits into from
Jun 10, 2024

Conversation

GitHNX
Copy link
Collaborator

@GitHNX GitHNX commented May 13, 2024 •
edited
Loading

Description

  • Added Internal Packages: config & logger
  • Updated discord_bot to use the new packages.

Fixes #36 (issue)

Type of change

  • Code Improvement (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@GitHNX GitHNX requested a review from serafdev May 13, 2024 23:14
@GitHNX GitHNX self-assigned this May 13, 2024
GitHNX
GitHNX commented May 13, 2024
View reviewed changes
cmd/discord_bot/main.go Outdated Show resolved Hide resolved
serafdev
serafdev reviewed May 16, 2024
View reviewed changes
cmd/discord_bot/main.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
@GitHNX
ISSUE-36 - Organize Environment and Logger init
8291c9c 
- Moving config to its own file
serafdev
serafdev approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@serafdev serafdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@GitHNX GitHNX merged commit 290418e into master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serafdev serafdev serafdev approved these changes

Assignees

@GitHNX GitHNX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organize Environment and Logger init
2 participants
@GitHNX @serafdev