Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle the absence of NSIS #303

Open
savornicesei opened this issue Jan 15, 2021 · 0 comments
Open

Gracefully handle the absence of NSIS #303

savornicesei opened this issue Jan 15, 2021 · 0 comments
Labels

Comments

@savornicesei
Copy link
Contributor

There are 2 situations where NSIS does not exists on the build system:

  1. it's not a Windows machine
  2. it was not installed

If NSIS is not available we should handle it gracefully in ccnet-packaging.inc.build, targets:

packageCCTray
packageCCTools
packageCCNET

I'm thinking if not on Windows it should display something like "CruiseControl.NET windows installers can only be created on Windows". But if the script runs on Windows but nsis.executable is empty / does not exist then it should fail the build.

Original discussion on PR #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant