Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph form overlap problem #2271

Closed
nikolas opened this issue Feb 17, 2023 · 0 comments
Closed

Graph form overlap problem #2271

nikolas opened this issue Feb 17, 2023 · 0 comments

Comments

@nikolas
Copy link
Member

nikolas commented Feb 17, 2023

Our responsive columns create an overlap issue with our hard-coded graph width:

Screenshot_2023-02-17_11-24-14

One solution I can think of is scaling the graph's SVG down in this case - possibly a CSS transform?

nikolas added a commit that referenced this issue Jun 28, 2023
This alleviates issue #2271.

It's not solved completely, but I think the SVG display area should have
a hard-coded color as a background. We are hard-coding all the line
colors themselves, so it's really designed with a white background in
mind.

Additionally, this CSS file was being included redundantly in many
templates: it only needs to be included in base.html if the template
inherits from base.
nikolas added a commit that referenced this issue Aug 1, 2023
This is a quick fix for #2271.

Negative margins are not good practice at all, but the
[CSS breakpoint](https://getbootstrap.com/docs/5.3/layout/breakpoints/)
when this occurs is not typically active.

Going forward, a more robust solution could be to allow the jsxgraph
view itself to have an adaptable width, but that is a big change, as a
lot of the Graph code takes advantage of the fact that we know the exact
graphical view width here of 540px.
@nikolas nikolas closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant