Protective Behaviors quiz style fixes - plain quiz conflicts #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,56 @@ | |||
|
|
|||
| {% getquestionresponse question as response %} | |||
|
|
|||
| {% if 'protective-behaviors' in question.quiz.pageblock.css_extra %} | |||
There was a problem hiding this comment.
Not sure you need all this...what issues are you seeing?
There was a problem hiding this comment.
You're right - this part was unnecessary. I removed it.
We need to address this issue:
ccnmtl/django-quizblock#35
so we don't have to deal with these problems!
nikolas
force-pushed
the
pb-style-fixes
branch
from
e30bd48
to
3afec0c
Compare
|
I think protective behaviors can be dealt with via .css. From what I've seen so far, everything but likert can share the same single_choice template without much problem. |
|
Alright - how should we resolve this then.. is it okay if I remove the |
removing special casing
nikolas
added a commit
that referenced
this pull request
Feb 24, 2015
Protective Behaviors quiz style fixes - plain quiz conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to address this issue:
ccnmtl/django-quizblock#35
so we don't have to deal with these problems!