Fix errors on two pages of ES6 Tutorial #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit incorporates the following fixes: 1. Rename webpack config entry from app to main This fix renames the entry 'app' back to 'main' in webpack.config.js. In webpack.config.js, the entries are defined as 'app' and 'ratefinder'. Due to this, the compiled js files will be app.bundle.js and ratefinder.bundle.js,which means the old main.bundle.js will never be updated. 2. Add code for showing table to index.html This commit adds a new point to part 1 of the Classes sub-tutorial, which adds the missing <table> element to index.html. Without this, the table will not be visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit incorporates the following fixes:
This fix renames the entry 'app' back to 'main' in webpack.config.js.
In webpack.config.js, the entries are defined as 'app' and
'ratefinder'. Due to this, the compiled js files will be app.bundle.js
and ratefinder.bundle.js,which means the old main.bundle.js will never
be updated.
This commit adds a new point to part 1 of the Classes sub-tutorial,
element to index.html. Without this,which adds the missing
the table will not be visible.