New COMPSP #7
Merged
New COMPSP #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the old compsp and replaces it with a subroutine that performs analytic integrals of the interpolation weights, to increase accuracy for certain SFHs, without increasing time_res_inc. It also significantly increases the modularity of compsp. intspec and intsfr have been removed, many new functions and subroutines have been added. However, the API of compsp remains unchanged. This commit also adds a gitignore, sets time_res_inc=1 and changes some other sps_vars.
This commit implements a tabular SFH option in csp_gen. It moves add_dust from compsp to csp_gen for speed reasons. Treatment of lbol is fixed. Warnings are added to compsp for certain parameter inputs. Numerous bugs are fixed in csp_gen and sfhinfo that affected the logic for relative component normalizations.
This commit includes fixes for many bugs in the sfhinfo logic affecting relative normalizations of different components of the SFH. It also corrects the slope and formed mass calculations used in the tabular SFH portions of csp_gen. sfhinfo returns interpolated sfrs for tabulated SFH.
|
Looking at |
|
in this case a simple tau-model will be used for the SFH.
… On Dec 12, 2016, at 2:06 PM, Benjamin Rose ***@***.***> wrote:
Looking at fburst and const, what happens if both are set to 0. I would assume that no SF would happen using the tau-model. But these lines, https://github.com/cconroy20/fsps/blob/master/src/sfhinfo.f90#L109 <https://github.com/cconroy20/fsps/blob/master/src/sfhinfo.f90#L109> https://github.com/cconroy20/fsps/blob/master/src/sfhinfo.f90#L119 <https://github.com/cconroy20/fsps/blob/master/src/sfhinfo.f90#L119>, confuse me.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHEQet8_Ut7P6q5ZSVplizF9ucUoJBouks5rHZslgaJpZM4IhVIq>.
|
|
Then I don't understand |
|
No, it's the fraction of mass formed in an instantaneous burst at time |
|
no, its the fraction of mass formed in an instantaneous burst.
… On Dec 12, 2016, at 2:21 PM, Benjamin Rose ***@***.***> wrote:
Then I don't understand fburst. I thought that was the fraction of mass formed in the tau-model burst.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHEQekbttWaPbKB5swgdyNxx6JWHZ5YUks5rHZ7HgaJpZM4IhVIq>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of COMPSP to do the convolution of the SSPs with SFH using analytic integrals. This means that
time_res_incnever needs to be larger than 1 to get accurate spectra. The call signature of the new COMSP is unchanged from the old version. Some variables were added to sps_vars, and a gitignore is added. Behavior has changed slighty in some respects, the most important arenzin> 1 raises an error in compsp. Only single metallicity SFHs are possible.sf_trunc<sf_startcauses a warning andsf_truncto be ignored, instead of giving a zero spectrum.fburstis applied at the same time asconstinstead of afterwards, sofburst> 0 does not alter the effectiveconst. Related to this, an error is raised iffburst + const> 1.tage> 0, iftburst>tagethen the burst is totally ignored. In old compsp the fluxes and masses were still decreased by a factor (1-fburst) in this case.tage=0 the returned SFRs integrate to (1.0-fburst) instead of 1.0. That is, the user must add the burst SFR themselves however they want to do that, but the sfrs for the other components are correct for the given stellar masses, etc. M/L and stellar mass history unchanged.