working but with limitations #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet. This is working! Thanks dude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ccorcos this is working but I had to use
absolutemode on theresolve-url-loader. But check the diff because there were several changes.With this example project I can see some interesting things.
I had forgotten that the project directory, per
process.cwd()was intended as a stop to the file search where there was nopackage.jsonorbower.jsonencountered. Since your script is running insideproj1then any references inproj2would not have worked. However there is a bug at line 102 which means that this did not effect you. Obviously I will need to relax the original intention and work out some other search limit.I now need to work out why the
absolutemode is necessary. We actually wanturl(proj2/javascript.png)to go through unchanged so that webpack can treat it as a module uri. But when this happens Webpack cannot resolve it.