Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slightly change validate() to support changing permissiveness #32

Closed
wants to merge 1 commit into from
Closed

slightly change validate() to support changing permissiveness #32

wants to merge 1 commit into from

Conversation

luke-c-sargent
Copy link

changed the signature and some docstring text to support non permissive validate(); enclosed the invocation in try/except to catch ValueError, the error thrown further in execution when permissive is False

tox tests passed, though i do not have all versions of python/numpy tested.

@luke-c-sargent luke-c-sargent mentioned this pull request Mar 3, 2022
Closed
@luke-c-sargent
Copy link
Author

see #31 for more info

@colinpalmer
Copy link
Member

The intended effect here was achieved in a different way; closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-c-sargent @colinpalmer