Error handling and Utilities added to Tw2TextureRes #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `CreateImageFromTexture` prototype and static method which create HTML IMG elements from a textureRes's WebGLTexture - Added `CreateBlobFromTexture` prototype and static method which create a png base 64 blob from the textureRes's WebGLTexture
cppctamber
changed the title
- Errors now caught on `Tw2TextureRes` - The resources `_isLoading` variable is correctly updated - The `onLoadFinished` callback is called if it exists - Error message emitted/ logged
cppctamber
changed the title
|
Export functions assume 2d texture. Can you handle other texture types (at least give an error)? |
|
Haven't figured out how to identify the texture type so will remove this until such time as I can! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateImageFromTextureprototype and static methods which create HTML IMG elements from a textureRes's WebGLTextureCreateBlobFromTextureprototype and static methods which create a png base 64 blob from the textureRes's WebGLTexture