Create the directory hierarchy necessary to preload the different files. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryzfeng
requested changes
Aug 29, 2024
qlambert-pro
force-pushed
the
preloadFilesInDirectories
branch
from
fb7d6b9
to
fe9d1d8
Compare
|
I amended my commit with your requests, let me know if you see anything else that should be addressed. |
terryzfeng
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM! Thank you for making these changes! ready for merge @gewang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at implementing what I have described here.
I suspect that my modifications make the lines creating the
chuginsdirectory redundant, but I am unsure, and couldn't test it as I am a beginner with chuck and am not yet familiar with chugins.Let me know, how I can improve this PR.