Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Random chugin to Rand #53

Closed
wants to merge 2 commits into from
Closed

Conversation

heuermh
Copy link
Contributor

@heuermh heuermh commented May 21, 2021

See heuermh/lick#11

Or alternatively, Rand could be called Gaussian or GaussianRandom.

@benrogmans
Copy link

+1

Would it make sense to prefix this collection of chugins to avoid any collisions in the future?

@heuermh
Copy link
Contributor Author

heuermh commented May 24, 2021

Would it make sense to prefix this collection of chugins to avoid any collisions in the future?

While we're at it, how about

Add namespaces and import statements ccrma/chuck#109 😉

@heuermh
Copy link
Contributor Author

heuermh commented Jul 20, 2021

Ping @gewang @spencersalazar @lathertonj for review

@heuermh
Copy link
Contributor Author

heuermh commented Jul 15, 2022

Ping @nshaheed for review

@spencersalazar
Copy link
Member

Im conflicted on this one -- Random is typically a 1st party-provided utility in many programming languages, and it seems like 3rd party libraries should use namespacing (whether actual namespaces or common prefixes) to avoid conflicts for things like this. Eventually I would think the Random chugin would expand to support more than just gaussian -- any assistance on improving it is also appreciated.

@heuermh
Copy link
Contributor Author

heuermh commented May 19, 2023

I'm backing down on this one 😉

Refactored LiCK RandomChance in commit 7392215

@heuermh heuermh closed this May 19, 2023
@heuermh heuermh deleted the rename-random branch May 19, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants