Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change K.1.4 CIN2/ungraded HSIL lookback to 2-3 years #69 #82

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

mrnosal
Copy link
Contributor

@mrnosal mrnosal commented Jun 14, 2023

Update logic For K.1.4 Heading 4.5 to check for two occurrences of CIN2/ungraded HSIL occur >=24 months and < 3 years of each other.

@mickohanlon23
Copy link
Contributor

Would you mind adding a test or two for this scenario, since this is directly to address an issue with one of the Test Script patients? Something that shows that a patient with two CIN2 results a year apart will not get this recommendation, but that that a patient with CIN2 results two years apart will get this recommendation. Might be helpful to recreate Test Patient 37 from the Test Scripts spreadsheet, since this was the patient that led to the discovery of this issue.

@mrnosal
Copy link
Contributor Author

mrnosal commented Jun 20, 2023

Added three test cases: one recreates Test patient 37, one has 2x CIN2 1 year apart (doesn't get recommendation) and one has 2x CIN2 two years apart (gets this recommendation).

Copy link
Contributor

@mickohanlon23 mickohanlon23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The test case for patient 37 shows that the recommendation we're giving now aligns with what is expected by the doctors! And the test case with 2 CIN2 results between 2-3 years apart is successfully giving this recommendation. Thanks for adding the tests!

@mickohanlon23 mickohanlon23 merged commit 4272311 into main Jun 21, 2023
@mickohanlon23 mickohanlon23 deleted the persisting-cin2 branch June 21, 2023 04:17
@mickohanlon23
Copy link
Contributor

Resolves issue #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants