Restrict conda-forge compilers for CI jobs #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation on Clang 14 appears to be incorrect for this combination of boost, python. In particular, in
dxtbx/src/dxtbx/boost_python/ext.cpp
Lines 196 to 198 in 23f28ff
_Py_Dealloc
near the top of the function without any kind of zero protections or checks:Whereas on clang 13 the calls to Dealloc are later, and include zero-protection around the calls (to _Py_Dealloc and the class destructors):
I am unsure if this difference is coming from the compiler, or from the newer build of python associated with this compiler that conda-forge selects when constraining the compiler. In any case, constraining the compiler works for now and hopefully the problem will be fixed before this becomes a problem.