Refactor SMV format classes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extract common get_raw_data spells into a common function
|
dxtbx, dials tests pass, no dxtbx 3 regressions. with above caveat of lacking test coverage. |
Closed
|
Merging this now. @dagewa is currently organizing some images that we can use for tests |
dagewa
added a commit
to dials/data-files
that referenced
this pull request
Aug 7, 2019
These are to be used to test the following Format classes: - FormatSMVTimePix_SU_512x512 - FormatSMVTimePix_SU_516x516 as noted in cctbx/dxtbx#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract common get_raw_data spells into a common function
as part of this work I noticed that the following format classes are not covered by tests: