✨ Defect-aware on-the-fly SiDB circuit designer #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… better re-usability
# Conflicts: # include/fiction/utils/truth_table_utils.hpp
…o neutral defects.
Signed-off-by: GitHub Actions <actions@github.com>
|
It seems not all references/calls to |
marcelwa
requested changes
Aug 16, 2024
include/fiction/algorithms/physical_design/on_the_fly_circuit_design_on_defective_surface.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
marcelwa
approved these changes
Aug 17, 2024
|
@marcelwa Many, many thanks for your tremendous work on this PR! |
My pleasure. However, you definitely did all the heavy lifting here. Great addition to the framework. I'm glad it's finally merged 🙂 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
defect-aware on-the-fly SiDB circuit designerand supports all 2 input functions.Checklist: