Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix DD node leak #385

Merged
merged 3 commits into from
Aug 3, 2023
Merged

🐛 Fix DD node leak #385

merged 3 commits into from
Aug 3, 2023

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Jul 27, 2023 •
edited
Loading

Description

Fixes #384

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer
🐛 fix node leak
da32f67 
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer
🩹 patch test
2a2800f 
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer
✅ add regression test
b1b16b1 
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added fix Fix for something that isn't working DD Anything related to the DD package c++ Anything related to C++ code labels Jul 27, 2023
@burgholzer burgholzer added this to the DD Package Improvements milestone Jul 27, 2023
@burgholzer burgholzer self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #385 (b1b16b1) into main (4819bcd) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #385   +/-   ##
=====================================
  Coverage   89.1%   89.1%           
=====================================
  Files         97      97           
  Lines      11708   11708           
  Branches    2101    2101           
=====================================
  Hits       10434   10434           
  Misses      1274    1274
Files Changed Coverage Δ
include/dd/Package.hpp 94.5% <100.0%> (ø)

@burgholzer
Copy link
Member Author

clang-tidy install is currently failing due to llvm/llvm-project#64120
Should resolve itself over time.

This was referenced Aug 1, 2023
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit db2299d into main Aug 3, 2023
46 checks passed
@burgholzer burgholzer deleted the fix-leak branch August 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@burgholzer burgholzer

Labels
c++ Anything related to C++ code DD Anything related to the DD package fix Fix for something that isn't working
Projects
MQT
Status: Done
MQT Core
Status: Done
Milestone
DD Package Improvements
Development

Successfully merging this pull request may close these issues.

🐛 DD Node Leak
1 participant
@burgholzer