-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow project installation #529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
added
feature
New feature or request
minor
Minor version update
Core
Anything related to the Core library and IR
packaging
Anything related to Python packaging
labels
Jan 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=====================================
Coverage 91.3% 91.3%
=====================================
Files 128 130 +2
Lines 13805 13851 +46
Branches 2151 2151
=====================================
+ Hits 12609 12655 +46
Misses 1196 1196
|
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
This was referenced Jan 12, 2024
Closed
burgholzer
added a commit
that referenced
this pull request
Jan 13, 2024
## Description This PR fixes a small oversight in #529 where one of the install instructions was not guarded properly. This should fix the issues observed in cda-tum/mqt-qcec#352. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up the project so that it can be installed properly.
As it is configured right now, this allows to install the
mqt-core
Python package and make the C++ project available viafind_package(mqt-core)
as long as the proper cmake directory is added to the search path.The right directory can easily be determined via
python -m mqt.core --cmake_dir
(or viamqt-core-cli --cmake_dir
).You might be wondering what this is useful for. It allows us to only require a single source copy of mqt-core in top-level projects once we switch them to using the
mqt-core
Python package. Otherwise, we would need to maintain the submodule and the Python package in parallel.While I expect this to require some follow ups once used in practice, I believe this is a solid start.
Fixes #504
Checklist: