Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 patch CI failure due to unconditional Qiskit deprecation warning #297

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

burgholzer
Copy link
Member

Description

Fixes CI. The newest Qiskit version introduced a new deprecation warning for some version attribute and, for some reason, that warning trips up pytest without our code actually using the deprecated attribute.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added python Anything related to Python code continuous integration Anything related to the CI setup fix Anything related to bugfixes labels Aug 8, 2023
@burgholzer burgholzer self-assigned this Aug 8, 2023
@burgholzer burgholzer enabled auto-merge (squash) August 8, 2023 11:00
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #297 (262499a) into main (7177f1a) will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #297     +/-   ##
=======================================
+ Coverage   95.9%   96.1%   +0.1%     
=======================================
  Files         34      34             
  Lines       1722    1720      -2     
  Branches     208     208             
=======================================
+ Hits        1653    1654      +1     
+ Misses        69      66      -3     
Flag Coverage Δ
cpp 95.8% <ø> (+0.2%) ⬆️
python 97.1% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@burgholzer burgholzer merged commit 0776067 into main Aug 8, 2023
33 checks passed
@burgholzer burgholzer deleted the patch-ci-failure branch August 8, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup fix Anything related to bugfixes python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant