Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 add configurable repo owner for mqt-core dependency #482

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

burgholzer
Copy link
Member

Description

This small PR adds a configuration option for the owner of the mqt-core dependency that is fetched via FetchContent. This should make it easier to point to forks of mqt-core.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Jun 24, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file usability Anything related to usability c++ Anything related to C++ code labels Jun 24, 2024
@burgholzer burgholzer enabled auto-merge (squash) June 24, 2024 14:33
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.4%. Comparing base (9a7fcf4) to head (8a14642).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #482     +/-   ##
=======================================
- Coverage   90.4%   90.4%   -0.1%     
=======================================
  Files         86      86             
  Lines       9982    9982             
  Branches    1696    1696             
=======================================
- Hits        9027    9025      -2     
- Misses       955     957      +2     
Flag Coverage Δ
cpp 90.1% <ø> (-0.1%) ⬇️
python 95.9% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit ae99f88 into main Jun 24, 2024
34 checks passed
@burgholzer burgholzer deleted the better-management-of-mqt-core-forks branch June 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant