player-rank #12
Merged
player-rank #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player now online requires battle_net_name. Submitting a replay now inflates player and associated rank model. Submitting a replay now calculates score change. Misc other changes which are hopefully improvements.
| player_rank.put() | ||
|
|
||
|
|
||
| def update_player_ranks(winning_player_ranks, losing_player_ranks): |
There was a problem hiding this comment.
I just calculate the average score of each team and then use that as if 1v1 and update player ranks based on calculated value. I think this should be fine. Does anyone see a problem?
Closed
| if isinstance(player_key, Key): | ||
| return player_key.get() | ||
| return PlayerModel.get_by_id(player_key) | ||
| season = season or Seasons.CURRENT_SEASON |
|
COMPLETE-OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhopkins-va @gholtslander-va
Apologies in advance if I took some of this in a direction different then originally intended. I just wanted the score to get calculated when a replay is uploaded. We can chat about this next week if you want.
Player now online requires battle_net_name.
Submitting a replay now inflates player and associated rank model.
Submitting a replay now calculates score change.
Misc other changes which are hopefully improvements.