Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FFI #1

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Update FFI #1

merged 1 commit into from
Sep 5, 2018

Conversation

aake
Copy link
Member

@aake aake commented Sep 4, 2018

Security vulnerability found in versions 1.9.23 and earlier:
https://nvd.nist.gov/vuln/detail/CVE-2018-1000201

Security vulnerability found in versions 1.9.23 and earlier:
https://nvd.nist.gov/vuln/detail/CVE-2018-1000201
@aake aake requested a review from kdole September 4, 2018 22:25
Copy link
Member

@kdole kdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.10! LGTM presuming the tests pass.

@aake
Copy link
Member Author

aake commented Sep 4, 2018

@kdole One test failing, but it was already failing before this change. 🤷‍♂️

Failure: test_file_charset_bang_exhaustively_checks_file_contents(MagicTest)
/Users/peter/Documents/libmagic/test/test_magic.rb:136:in `test_file_charset_bang_exhaustively_checks_file_contents'
     133:   def test_file_charset_bang_exhaustively_checks_file_contents
     134:     # huge_file_with_one_special_character.csv
     135:     t1 = Time.now
  => 136:     assert_equal("us-ascii", Magic.file_charset(absolute_path("huge_file_with_one_special_character.csv")))
     137:     assert_equal("iso-8859-1", Magic.file_charset!(absolute_path("huge_file_with_one_special_character.csv")))
     138:     puts "took #{Time.now - t1} seconds"
     139:   end
<"us-ascii">(UTF-8) expected but was
<"iso-8859-1">(ASCII-8BIT)

@kdole
Copy link
Member

kdole commented Sep 4, 2018

That is disappointing. Does Vault correctly import that file (does the non-ascii character show correctly as UTF-8 in Vault)?

@aake
Copy link
Member Author

aake commented Sep 5, 2018

Yes, when slurped the value is stored as UTF-8.

@aake aake merged commit d3a113f into master Sep 5, 2018
@aake aake deleted the update-ffi branch September 5, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants