Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argon2 fix #45

Merged
merged 12 commits into from
Mar 7, 2021
Merged

Argon2 fix #45

merged 12 commits into from
Mar 7, 2021

Conversation

Vlix
Copy link
Collaborator

@Vlix Vlix commented Feb 14, 2021

Should fix the inconsistency pointed out in #42

@Vlix Vlix added this to the password(-instances) 3.0.0.0 milestone Feb 15, 2021
@Vlix
Copy link
Collaborator Author

Vlix commented Feb 16, 2021

Ok, finally, all other PRs are merged.
This is the final PR before we release 3.0.0.0 and password-types

Also, I didn't credit the reporter of #42 since it seems to be a throwaway account. (jdoe0000000)

@jdoe0000000
Copy link

Also, I didn't credit the reporter of #42 since it seems to be a throwaway account. (jdoe0000000)

I can confirm that this is a (semi)throwaway account -- I only use once in a while to submit bug reports and minor PRs -- so no need to credit me.

Copy link
Owner

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Thanks for bringing it up @jdoe0000000.

@Vlix
Copy link
Collaborator Author

Vlix commented Mar 4, 2021

Also, I didn't credit the reporter of #42 since it seems to be a throwaway account. (jdoe0000000)

I can confirm that this is a (semi)throwaway account -- I only use once in a while to submit bug reports and minor PRs -- so no need to credit me.

Thank you for confirming @jdoe0000000 👍

I've wanted to merge this and release 3.0.0.0 for like 1-2 weeks now, but was a bit busy.
Will clean up the repo and release this weekend, I think.

@Vlix Vlix merged commit e90b748 into master Mar 7, 2021
@Vlix Vlix deleted the argon2-fix branch March 7, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants