-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argon2 fix #45
Argon2 fix #45
Conversation
… added padding when checking the hash
…padding checks out
Ok, finally, all other PRs are merged. Also, I didn't credit the reporter of #42 since it seems to be a throwaway account. ( |
I can confirm that this is a (semi)throwaway account -- I only use once in a while to submit bug reports and minor PRs -- so no need to credit me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Thanks for bringing it up @jdoe0000000.
Thank you for confirming @jdoe0000000 👍 I've wanted to merge this and release 3.0.0.0 for like 1-2 weeks now, but was a bit busy. |
Should fix the inconsistency pointed out in #42