Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CloudEvents id is not set #57

Closed
afrittoli opened this issue Jun 26, 2023 · 0 comments · Fixed by #58
Closed

The CloudEvents id is not set #57

afrittoli opened this issue Jun 26, 2023 · 0 comments · Fixed by #58

Comments

@afrittoli
Copy link
Contributor

According to the CDEvents spec, the CloudEvents id field must match the CDEvents id field. The AsCloudEvent method should set the CloudEvents id, but it does not today.
afrittoli added a commit to afrittoli/cdevents-sdk-go that referenced this issue Jun 26, 2023
@afrittoli
Set the CloudEvent ID to match CDEvents Id
18a565a 
When using the CloudEvent binding, the CloudEvent ID must match,
according to the specification, with the CDEvents Id.

This can be done today by the event producer via the CloudEvents
and CDEvents SDKs, however, since it's required by the spec,
it's better implemented as default by the CDEvents SDK directly.

Fixes: cdevents#57

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli mentioned this issue Jun 26, 2023
Merged
afrittoli added a commit that referenced this issue Jun 26, 2023
@afrittoli
Set the CloudEvent ID to match CDEvents Id
39341b2 
When using the CloudEvent binding, the CloudEvent ID must match,
according to the specification, with the CDEvents Id.

This can be done today by the event producer via the CloudEvents
and CDEvents SDKs, however, since it's required by the spec,
it's better implemented as default by the CDEvents SDK directly.

Fixes: #57

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the CloudEvent ID to match CDEvents Id afrittoli/cdevents-sdk-go
1 participant
@afrittoli