Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GoLang errors in readme #35

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

bradmccoydev
Copy link
Member

Fix GoLang errors in README.md for sending cloudevent.

Closes issue: #34

Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
README.md Show resolved Hide resolved
README.md Outdated
Comment on lines 71 to 73
if err != nil {
log.Fatalf("failed to create client, %v", err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems off here

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A couple of small comments

Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@afrittoli afrittoli merged commit 44b9ed1 into cdevents:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants