Update source code change terminology #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erkist +1 for this change |
erkist
commented
Jul 19, 2021
| - **Change Proposal Reviewed Event**: someone (user) or an automated system submitted a review to the source code change proposal. A user or an automated system needs to be in charge of understanding how many approvals/rejections are needed for this change proposal to be merged or rejected. The review event needs to include if the change proposal is approved by the reviewer, more changes are needed or if the change proposal is rejected. | ||
| - **Change Proposal Abandoned Event**: a tool or a user decides that the change proposal should be abandoned, for instance because it has been inactive for a while. | ||
| - **Change Proposal Updated**: the change proposal has been updated, for example a new commit is added or removed from an existing change proposal. | ||
| - **Change Merged Event**: the change proposal is made a change by it being merged to the target branch where it was submitted. |
There was a problem hiding this comment.
Rename to Change Proposal Merged for consistency
m-linner-ericsson
approved these changes
Oct 22, 2021
|
@erkist Thank you for this! Since we now have https://github.org/cdevents/spec, would you mind re-submitting your PR there? Thank you! |
|
@erkist shall we merge this anyways or close it? |
|
@erkist @afrittoli This is still not in the CDEvents spec right? |
|
Closing this PR here, as the spec has moved to cdevents org. An issue is created there to cater for this proposal instead. If still relevant, a new PR needs to be created there instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to rename source code change to source code change proposal, as per discussion #34
Note: The Change Merged event is not referred to as a proposal. My reasoning is that it stops being a proposal and becomes an actual change when it is being merged. But I don't have a strong opinion on it, it might be better to refer to it as a change proposal here as well, for consistency.