Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt.Errorf format %v reads arg #2, but call has 1 arg #23

Closed
ashnair1 opened this issue Jul 19, 2021 · 4 comments · Fixed by #24
Closed

fmt.Errorf format %v reads arg #2, but call has 1 arg #23

ashnair1 opened this issue Jul 19, 2021 · 4 comments · Fixed by #24

Comments

@ashnair1
Copy link
Contributor

This line in kmeans throws an error fmt.Errorf format %v reads arg #2, but call has 1 arg while running tests.

A simple fix would be to replace the line in question

errors <- fmt.Errorf("ERROR: point.X must have the same dimensions as clusters (len %v). Point: %v", point)

with this

errors <- fmt.Errorf("ERROR: point.X must have the same dimensions as clusters (len %v). Point: %v", centroids, point)

Follow up question, is this project in active development?

@piazzamp
Copy link
Collaborator

👋 hey Ashwin!
sorry about that! would you like to submit a PR with that change?

and no this project is not in active development and I don't think Conner has plans to resume adding to goml in the near future and I definitely don't

@ashnair1
Copy link
Contributor Author

Submitted the PR. Thanks for the clarification.

@ashnair1 ashnair1 mentioned this issue Jul 24, 2021
@ashnair1
Copy link
Contributor Author

Hi @piazzamp. If you don't mind, could you take a look at the PR (#24)?

piazzamp added a commit that referenced this issue Jul 15, 2022
Fix #23: log out the number of centroids
@piazzamp
Copy link
Collaborator

Hey Ashwin - thank you for the follow-through here! I um got distracted for a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants