Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 3 1 #14

Merged
merged 16 commits into from
Jul 24, 2023
Merged

Sprint 3 1 #14

merged 16 commits into from
Jul 24, 2023

Conversation

jared-schreibman-cdisc
Copy link
Contributor

Model updates
Created output_wrapper to wrap study

@dih-cdisc
Copy link
Collaborator

dih-cdisc commented Jul 19, 2023

  • 'id' is used in all classes, should be defined once rather than in each class for maintainability reasons, we may wish to provide a better def in the future (say a regex)
  • Same as 'id' for 'name' and 'description' where updated
  • The Id and Ids fields should not be modified, see model -> API rules . We now need to "convert" the model into an API, this means following those rules to modify attributes where we need a cross reference. So model name 'epoch' -> 'epochId' and the plural ones xxxs-> 'xxxIds'

@jared-schreibman-cdisc
Copy link
Contributor Author

@daveih Updated to revert the changes back to using ids and id in their respective place

@jared-schreibman-cdisc
Copy link
Contributor Author

@daveih Refactored id, name, and description inheritance into their own classes

@jared-schreibman-cdisc jared-schreibman-cdisc merged commit 8656535 into main Jul 24, 2023
@jared-schreibman-cdisc jared-schreibman-cdisc deleted the sprint-3-1 branch July 24, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants