-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing stereo in CXSMILES depiction #48
Comments
Polymers and CIP :-). Unfortunately there are no rules (that I know of) for how CIP applies to polymers, do we weight the DUMMY atom infinitely heavy or light? For now it is safer to give no answer, in this case you get the same answer regardless but not always the case. If I remember how the code works, if it can split ties before it "reaches" a DUMMY atom it gives you an answer it does, a slight modification shows this works as we expect:
The issue is the tie isn't split till you reach the C(=O)(*) at which point it sees dummy atom and gives up. In this case I think it is pos. to prove it's unambiguous - but extra logic is needed.
Perhaps the most sane thing to do here is actually to cyclise the structure
S is correct here as we could also put in duplicates on each end and take the middle value: |
Right, yes, I guess that makes sense... I was thinking about the DUMMY being the repeat unit again, but that's not the case for all monomers, of course. |
The centres/cip code is not polymer aware but yeah a reasonable approximation here would be to triplicate and then name it |
I consider it a future wishlist |
Could you open issue tagged as feature request on centres repo please |
|
Given two (CX)SMILES:
and
CIP Stereo Labeling
turned on, only the SMILES and not the CXSMILES shows the CIP label:The text was updated successfully, but these errors were encountered: