Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4 #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue #4 #8

wants to merge 3 commits into from

Conversation

nagasrisai
Copy link

No description provided.

@cdkini
Copy link
Owner

cdkini commented Jan 18, 2021

Hello! Thanks for contributing to my small project :)

I put those issues as more of a reminder for myself but I'm happy to have you tackle them if you wish. I didn't really explain issue #4 in detail so let me elaborate a bit. This issue was focused on both cleaning up the formatting as well as modularizing the code.

If you'd like to tackle this issue, could you please do the following:

  1. Move all in-line CSS and JavaScript into separate files (the current styles.css and script.js should suffice).
  2. Wrap everything in script.js into helper functions and add comments as necessary.
  3. Format everything using prettier.
  4. Ensure that the program still builds and executes as intended (git clone, go get, go build, go run main.go).
  5. Squash all commits into a single one using git rebase -i HEAD~n and renaming the single commit to adhere to the commit guidelines noted in README.md. Something like refactor(#4/frontend): Refactor in-line CSS and JS along with a description as to what you've changed would be perfect.

Let me know if you're still interested in tackling this and if you have any questions.

@nagasrisai
Copy link
Author

Sure please assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants