chore(ir): add specific error message when an invalid resource property is used

[colifran]

In the event that an invalid property is specified for a specific resource type the value_type will be None causing the other arm of the match statement below to execute.

cdk-from-cfn/src/ir/resources/mod.rs

Lines 119 to 129 in 2c14390

	ResourceValue::Object(o) => {
	let property_bag: Box<dyn PropertyBag> = match &self.value_type {
	Some(TypeReference::Named(name)) => {
	Box::new(self.schema.type_named(name).cloned().unwrap())
	}
	Some(TypeReference::Map(item_type)) => Box::new(MapOf(item_type)),
	Some(TypeReference::Primitive(Primitive::Json)) => {
	Box::new(MapOf(&TypeReference::Primitive(Primitive::Json)))
	}
	other => unimplemented!("{other:?}"),
	};

Due to the unimplemented! macro panicking in-place, a non-descriptive error message is displayed while using cdk migrate:

cdk migrate --from-path './CDKMigrateExampleTemplate.yml' --stack-name CustomStackName
...
 ❌  Migrate failed for `CustomStackName`: stack generation failed due to error 'unreachable'

stack generation failed due to error 'unreachable'

This PR adds a new explicit check for the case where property_type is None. If that case is true, then a more descriptive error message will be displayed explaining what resource property is not valid. For example,

cdk migrate --from-path './CDKMigrateExampleTemplate.yml' --stack-name CustomStackName
...
 ❌  Migrate failed for `CustomStackName`: stack generation failed due to error 'ReadEndpoint is not a valid resource property for resource RDSCluster of type AWS::RDS::DBCluster'

stack generation failed due to error 'ReadEndpoint is not a valid resource property for resource RDSCluster of type AWS::RDS::DBCluster'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

Merging #594 (15f20dc) into main (2c14390) will increase coverage by 0.2%.
The diff coverage is 94.1%.

Additional details and impacted files

Components	Coverage Δ
Parser	76.2% <ø> (ø)
Intermediate Representation	80.4% <94.1%> (+0.9%)	⬆️
Synthesizers	87.3% <ø> (ø)
Other	35.0% <ø> (+0.7%)	⬆️

@@           Coverage Diff           @@
##            main    #594     +/-   ##
=======================================
+ Coverage   81.0%   81.2%   +0.2%     
=======================================
  Files         27      27             
  Lines       5098    5110     +12     
  Branches    5098    5110     +12     
=======================================
+ Hits        4130    4148     +18     
+ Misses       766     761      -5     
+ Partials     202     201      -1     

Files	Coverage Δ
src/ir/resources/mod.rs	79.9% <94.1%> (+1.4%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c14390...15f20dc. Read the comment docs.

[TheRealAmazonKendra]

Could we wordsmith that error a little more? Maybe some thing more like: ${stackName} could not be generated because <the rest of your error message is great>

[TheRealAmazonKendra]

Neverminddddd, that part of the error message is on the CLI side so approving this since it looks great!