Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure support for intrinsics YAML shorthand #270

Closed
mrgrain opened this issue Sep 14, 2022 · 2 comments · Fixed by #338
Closed

Ensure support for intrinsics YAML shorthand #270

mrgrain opened this issue Sep 14, 2022 · 2 comments · Fixed by #338
Assignees

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Sep 14, 2022

In Yaml, a user can write !GetAtt MyBucket.BucketName or !Ref MyBucket to refer to intrinsic functions.

Currently we don't have any tests or examples covering these. Need to make sure we support them everywhere.

Also need to check:

  • Does it work with Yaml Schema Validation?
  • Does it work with custom Intrinsic Functions? (Currently only CDK::GetProp) Should it?
@mrgrain
Copy link
Contributor Author

mrgrain commented Sep 23, 2022

Looks like there is some support for it already:

const shortForms: yaml_types.Schema.CustomTag[] = [

@lejiati
Copy link
Contributor

lejiati commented Sep 23, 2022

Yea it does. I tested with a sample template and it indeed passed test suite. But lacking support for parameter/condition/mapping limits what tests case we can have. So I'm thinking we can defer this task until more features were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants