Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: schema can validate intrinsic functions where primitives are expected #263

Merged
merged 7 commits into from
Sep 15, 2022
Merged

feat: schema can validate intrinsic functions where primitives are expected #263

merged 7 commits into from
Sep 15, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 13, 2022 •
edited
Loading

First part of #49

  • Adds proper JsonSchema for Intrinsics
  • Test suite for AST support (which was already there)
  • One fix for AST and evaluation of Join/Select intrinsics

Coming in a follow-up:

  • Test suite for evaluation
  • Context for intrinsics

@mrgrain mrgrain force-pushed the mrgrain/feat/allow-intrinsics-as-primitives branch 2 times, most recently from 13b0ad1 to 9c7a3ef Compare September 13, 2022 10:46
@mrgrain mrgrain changed the title feat: can use intrinsic functions where primitives are expected feat: schema can validate intrinsic functions where primitives are expected Sep 14, 2022
@mrgrain mrgrain marked this pull request as ready for review September 14, 2022 10:44
@mrgrain mrgrain force-pushed the mrgrain/feat/allow-intrinsics-as-primitives branch from bde8d86 to 57bf90d Compare September 14, 2022 10:58
mrgrain
mrgrain commented Sep 14, 2022
View reviewed changes
examples/lambda-policy.yaml
- s3:GetObject*
- s3:PutObject*
Resource:
- { Fn::GetAtt: MyBucket.bucketArn }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be {Ref: MyBucket} but there is another issue with this right now that I will address later.

@mrgrain mrgrain mentioned this pull request Sep 14, 2022
Closed
@mrgrain mrgrain force-pushed the mrgrain/feat/allow-intrinsics-as-primitives branch from 1c035bc to 75f5a1e Compare September 15, 2022 08:53
chore: self mutation
5343159 
Signed-off-by: github-actions <github-actions@github.com>
@mergify mergify bot merged commit 87b7968 into main Sep 15, 2022
@mergify mergify bot deleted the mrgrain/feat/allow-intrinsics-as-primitives branch September 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrgrain @otaviomacedo